E.M.
Dear M.,
I briefly (for about nine months) worked for MetLife, went through the licensing procedures and sold life insurance, health insurance, and mutual funds. This was some number of years ago, I'm not licensed anymore, and I wouldn't want to be the only voice advising you on helping your children's future.
That said, because I was selling insurance I decided to go through the same process as my clients even though I do not have any children (for me, it was important to know that my parents would benefit in some way if I predeceased them). I looked very carefully through the MetLife plans and several others, and did purchase Whole Life. When advising clients, I made sure to find out THEIR feelings about risk, their sense of how long their needs for what kinds of insurance would be, and that they were reasonably able to afford coverage they felt was correct for them and their families.
New York Life is a well respected company. Whole Life is one of many options, and if you sense that it is the way for you to feel that you are doing your best to ensure that your children will have some buffer in extreme crisis, or at the most difficult of times, there is good reason to be comfortable with your decision, so long as the company is able to keep its word with respect to payment (and New York Life is in a category where it is well expected to do so).
Some people, like my father, see life insurance as a waste of money because the same amount can be invested over time to grow in (decent) investments, for more financial benefit over time. This is true so long as time horizons are sufficient, and for most people, they usually are. However, I understand your feeling about trying to cover all bases that are reasonable with respect to your children, and if you can afford both life insurance and to set things aside for your own future and theirs, all the better.
I stopped selling insurance when I started finding clients who could easily and reasonably afford it, ironically, because their children were at the least risk for having the most difficulty at the time of a parents' passing. That said, it is an honorable product so long as the company fulfills its promise, and as someone who worked for a different insurance company (which prided itself on its payments, its reason for being, and which I saw make payments...), please just know that New York Life is well respected.
I wish you and your family the best! And yes, you're right -- while you are younger, healthier, and able to make payments without hardship is the optimum time to participate if you can. By the way, I think your children are extremely lucky that they have you. No need to "overinsure" -- and you can always add less expensive term policies later (assuming fair enough health) if it seems that augmenting your whole life policy is important for specific times, such as helping to ensure that children get through educations if they are, for example, out of state....
Best wishes,
E.